[Bug 446411] Review Request: perl-Event-Lib - Perl wrapper around libevent

bugzilla at redhat.com bugzilla at redhat.com
Tue May 27 11:40:23 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Event-Lib - Perl wrapper around libevent


https://bugzilla.redhat.com/show_bug.cgi?id=446411


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-05-27 07:40 EST -------
oops sorry I missed this review from my review list.

Review:
+ package builds in mock (rawhide i386).
koji build=http://koji.fedoraproject.org/koji/taskinfo?taskID=630225
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
90b60028f7f5836072e95c6d5b1d069e  Event-Lib-1.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test output is
All tests successful.
Files=36, Tests=4280, 56 wallclock secs ( 8.13 cusr +  1.05 csys =  9.18 CPU)
+ Package perl-Event-Lib-1.03-2.fc10 =>
  Provides: Lib.so perl(Event::Lib) = 1.03
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libevent-1.3e.so.1 perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(Exporter)
perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list