[Bug 225752] Merge Review: filesystem

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: filesystem


https://bugzilla.redhat.com/show_bug.cgi?id=225752





------- Additional Comments From pknirsch at redhat.com  2008-05-27 11:26 EST -------
> filesystem.src: E: non-utf8-spec-file
> /tmp/filesystem-2.4.11-1.fc8.src.rpm.12176/filesystem.spec
> The character encoding of the spec file is not UTF-8.  Convert it for
> example using iconv(1).
> 
> Fix.

Fixed. Was only Trond's name that caused problems.

> filesystem.src: W: no-%build-section
> The spec file does not contain a %build section.  Even if some packages
> don't directly need it, section markers may be overridden in rpm's
> configuration to provide additional "under the hood" functionality, such as
> injection of automatic -debuginfo subpackages.  Add the section, even if
> empty.
> 
> Fix.

Added an empty %build section. Fixed.

> filesystem.src: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line 28)
> The specfile mixes use of spaces and tabs for indentation, which is a
> cosmetic annoyance.  Use either spaces or tabs for indentation, not both.
> 
> Cosmetic, but easy to fix.

Fixed. Only the 2 tabs in the echo commands remain, but those are output
redirected to a config file where tabs are commonly used, so that should be ok.

> filesystem.src: E: tag-not-utf8 %changelog
> The character encoding of the value of this tag is not UTF-8.
> 
> Fix.

Fixed already by UTF-8 conversion.

> filesystem.src: W: no-url-tag
> The URL tag is missing.
> 
> Fix.  If we're upstream, get a spot on hosted for this.  Also, since the license
> is listed as Public Domain, we either need something in the one file of source
> there is, the lang-exceptions file, or have something in %doc stating the license.

Hm, good point. Would a webpage on fp.org be enough you think? I could a
standard Public Domain copyright notice there and add that to the
lang-exceptions file as well and use this as the URL/homepage for the project,
too. As there is no source whatsoever i think a single webpage should be enough.

> filesystem.i386: W: no-documentation
> The package contains no documentation (README, doc, etc).
> You have to include documentation files.
> 
> Is there anything to include here?

Not really. The filesystem component really only provides the directory skeleton
structure for the OS and owns those "general" directories. Adding a doc file to
it would kind of contradict this skeleton function of this component, so if
possible i'd rather not do it.

> filesystem.i386: E: no-binary
> The package should be of the noarch architecture because it doesn't contain
> any binaries.
> 
> Should this be made noarch, or would that break the _lib arch conditional?

The problem is with /lib vs /lib64 and /usr/lib vs /usr/lib64, so yes, it's
because of the _lib arch conditional. If you see a way to avoid that without
adding all 4 trees with all subtrees to the noarch package i'm all ears.

> Duplicate files:
> warning: File listed twice: /usr/share/locale/ca_ES at valencian
> warning: File listed twice: /usr/share/locale/ca_ES at valencian/LC_MESSAGES

Hm, i've ran an rpmlint on the latest Feodra Devel package and don't get that
error. Could you reverify that you get this error and with which packages and
installation?

I've already done the changes which were easy to fix and await your answer for
the remaining points. In the meantime i'll build a new package that already
contains those fixes.

Thanks a lot,

Read ya, Phil


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.