[Bug 445347] Review Request: python-shout - python binding for libshout

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-shout - python binding for libshout


https://bugzilla.redhat.com/show_bug.cgi?id=445347


bdpepple at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From bdpepple at gmail.com  2008-05-27 15:32 EST -------
MD5Sum:
80bec97a1462c2d2a9282ba8a7c18336  shout-python-0.2.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Files have appropriate permissions and owners
* Rpmlint does not find problems
* Package installs and uninstalls cleanly

Minor:
* Looking at the header of shout.c, it looks like the license tag should be
LGPLv2+, not LGPLv2.

+1 APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.