[Bug 443771] Review Request: lmms - Linux MultiMedia Studio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lmms - Linux MultiMedia Studio


https://bugzilla.redhat.com/show_bug.cgi?id=443771





------- Additional Comments From kwizart at gmail.com  2008-05-27 20:30 EST -------
Ok - we need to have festival-devel and festival-speechtools-devel fixed first.
Need to have (STK) packaged also.

So, few others notes.
* Qt i18n 
configure:21663: checking Qt translations
configure:21679: WARNING: *** not found! You may want to install a Qt i18n package
I don't know any package that provides that, but you may want to check
acinclude.m4 where live the gw_CHECK_QT function. and probably remove it to pick
a nicer m4 for qt detection. ( for pathes on lib64 and to not hardcode the
needed library).

* Source0
http://downloads.sourceforge.net/lmms/lmms-%{version}.tar.bz2
instead of 
http://prdownloads.sourceforge.net/lmms/lmms-0.3.2.tar.bz2

* You can use:
%configure --disable-static \
%ifnarch i386
--without-vst \
%endif
<space>

* You need to use make %{?_smp_mflags} (unless it fails and you need to drop a
comment if it does.

* Prevent timestramps changes at install :
 make DESTDIR=%{buildroot} install INSTALL="install -p"

* CFLAGS : -ftree-vectorize -ftree-loop-linear are used and may override some of
our CFLAGS (or not - anyway we may need to see if this is really needed).

* post/postun
update-mime-database %{_datadir}/mime &> /dev/null || :
update-desktop-database &> /dev/null || :
 You need to add full path for them like /usr/bin/update-desktop-database
and remove the &> /dev/null (as if it fails, we will not know)
only the last || : would be needed

* desktop file 
- Usually GNOME HIG compliance requires to use verbs in Comments
- Icon and Exec should mention the path (and .png)
It would be fine to drop a symlink into /usr/share/pixmaps 
- X-Desktop-File-Install-Version=0.3 is written before desktop-file-install is used.
- Categories / "MimeType" is a list and does not have a semicolon as trailing
character, fixing - this could be fixed at source also.

- License is GPLv2+ - OK




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.