[Bug 444511] Review Request: emma - Java code coverage tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emma - Java code coverage tool


https://bugzilla.redhat.com/show_bug.cgi?id=444511





------- Additional Comments From fitzsim at redhat.com  2008-05-27 23:15 EST -------
- MUST: rpmlint must be run on every package. The output should be posted...

$ rpmlint SRPMS/emma-2.0-0.5312.2jpp.1.fc9.src.rpm 

OK

$ rpmlint RPMS/noarch/emma-2.0-0.5312.2jpp.1.fc9.noarch.rpm 
emma.noarch: W: non-conffile-in-etc /etc/maven/fragments/emma

Explain

$ rpmlint RPMS/noarch/emma-javadoc-2.0-0.5312.2jpp.1.fc9.noarch.rpm 

OK

- MUST: The package must be named according to the Package Naming Guideli...

OK

- MUST: The spec file name must match the base package %{name}, in the fo...

OK

- MUST: The package must meet the Packaging Guidelines .

OK.  Do you want to leave the Epoch tag?

- MUST: The package must be licensed with a Fedora approved license and m...

OK

- MUST: The License field in the package spec file must match the actual ...

OK

- MUST: If (and only if) the source package includes the text of the lice...

OK

- MUST: The spec file must be written in American English.

OK

- MUST: The spec file for the package MUST be legible. If the reviewer is...

OK

- MUST: The sources used to build the package must match the upstream sou...

OK

- MUST: The package must successfully compile and build into binary rpms ...

OK

- MUST: If the package does not successfully compile, build or work on an...

OK

- MUST: All build dependencies must be listed in BuildRequires, except fo...

OK

- MUST: The spec file MUST handle locales properly. This is done by using...

OK

- MUST: Every binary RPM package which stores shared library files (not j...

OK

- MUST: If the package is designed to be relocatable, the packager must s...

OK

- MUST: A package must own all directories that it creates. If it does no...

What package should own %{_datadir}/maven2 and
%{_datadir}/maven2/poms?  They're unowned on my Fedora 9 system.

- MUST: A package must not contain any duplicate files in the %files list...

OK

- MUST: Permissions on files must be set properly. Executables should be ...

The base defattr line should use '-' for permissions.

- MUST: Each package must have a %clean section, which contains rm -rf %{...

OK

- MUST: Each package must consistently use macros, as described in the [w...

OK

- MUST: The package must contain code, or permissable content. This is de...

OK

- MUST: Large documentation files should go in a -doc subpackage. (The de...

OK

- MUST: If a package includes something as %doc, it must not affect the r...

OK

- MUST: Header files must be in a -devel package.

OK

- MUST: Static libraries must be in a -static package.

OK

- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfi...

OK

- MUST: If a package contains library files with a suffix (e.g. libfoo.so...

OK

- MUST: In the vast majority of cases, devel packages must require the ba...

OK

- MUST: Packages must NOT contain any .la libtool archives, these should ...

OK

- MUST: Packages containing GUI applications must include a %{name}.deskt...

OK

- MUST: Packages must not own files or directories already owned by other...

%{_mavendepmapfragdir} is owned by other packages.

- MUST: At the beginning of %install, each package MUST run rm -rf %{buil...

OK

- MUST: All filenames in rpm packages must be valid UTF-8.

OK

- SHOULD: If the source package does not include license text(s) as a sep...

OK

- SHOULD: The description and summary sections in the package spec file s...

OK

- SHOULD: The reviewer should test that the package builds in mock. See [...

fedora-9-i386 mock build fails.

- SHOULD: The package should compile and build into binary rpms on all su...

OK on i386

- SHOULD: The reviewer should test that the package functions as describe...

emma -help works

- SHOULD: If scriptlets are used, those scriptlets must be sane. This is ...

OK

- SHOULD: Usually, subpackages other than devel should require the base p...

javadoc doesn't require base package but that's expected.

- SHOULD: The placement of pkgconfig(.pc) files depends on their usecase,...

OK

- SHOULD: If the package has file dependencies outside of /etc, /bin, /sb...

OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.