[Bug 444763] Review Request: vaspview - VASP Data Viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vaspview - VASP Data Viewer


https://bugzilla.redhat.com/show_bug.cgi?id=444763


kwizart at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |kwizart at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From kwizart at gmail.com  2008-05-28 07:51 EST -------

 - starting review -

Few notes: 
* vendor field should remains empty
desktop-file-install --vendor="" \

* Why there is no dist macro for the release tag ?

* last source is 2001/08, this is old. (but it still work without patch, unless
for the missing  "no newline at end of file" which doesn't seems to matter much
for now).
There could be a problem to package software when upstream is dead, as this
package could be improved (it cannot open a dialog window when opening a file).
Visualization remains hard, etc.

* The source tarball used, bundles a pre-built binary for win32. It have to be
removed.

So there may be one suggestion. I wonder if the project could be merged with
GLC_player. That's a 3D model visualization tool for the obj format. Anyway i
think it worst the case to ask... Note that if the package is useful as it is, I
don't see any blocker by itself...


 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.