[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications


https://bugzilla.redhat.com/show_bug.cgi?id=446414


xavier at bachelot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org




------- Additional Comments From xavier at bachelot.org  2008-05-28 11:18 EST -------
+ source files match upstream : 904f6fe4b94248b56507710b29a53873
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock ( ).
+ package installs properly
- rpmlint is silent :
file-not-utf8 /usr/share/man/man3/Gtk2::Ex::FormFactory::*.3pm.gz

- final provides and requires are sane:
These provides are bogus :
perl(Music::Album)
perl(Music::Artist)
perl(Music::Config)
perl(Music::DBI)
perl(Music::Genre)
perl(Music::Song)

This is weird as the doc files that induce that are not executable.

+ %check is present and all tests pass
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

Also, package is noarch, replace "make %{?_smp_mflags}" by a simple "make"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.