[Bug 435016] Review Request: mmdb - MMDB coordinate library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mmdb - MMDB coordinate library


https://bugzilla.redhat.com/show_bug.cgi?id=435016





------- Additional Comments From fenn at stanford.edu  2008-05-28 21:40 EST -------
(In reply to comment #4)
> Similar issues as with ssm:
> 

All comments to ssm propogated here.

> * 
> # rpmlint mdb-1.09.1-5.fc9.x86_64.rpm 
> mmdb.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmmdb.so.0.0.0
> mmdb.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmmdb.so.0.0.0
> Your main package needs ldconfig scriptlets
> 

Done.

> mmdb.x86_64: W: no-version-in-last-changelog
> Please appropriate version numbers to your changelog entries in mmdb.spec
> 

Done.

> * BuildRoot doesn't comply to FPG
> 

Fixed.

> * mmdb-devel.x86_64: W: no-dependency-on mmdb
> The *-devel package must depend upon the main-package
> => Add
> Requires: mmdb = %{version}-%{release}
> to *-devel
> 

Fixed.

> * mmdb-devel contains *.pc
> => Add
> Requires: pkgconfig
> to *-devel
> 

Fixed.

> * mmdb-devel contains binaries and temporary files (*.o, .libs) in
> /usr/share/doc/mmdb-devel-1.09.1/Examples
> This is doesn't work, is multiply broken and therefore is not allowed.
> The easiest work-around to this is not to ship these files.
> 
> If you want to ship the sources, you'd have to remove all binaries and temporary
> files from ../doc/../Examples in %install
> 

I added the following to %install:

pushd Examples ; make clean ; rm -rf .deps _deps ; popd

is that OK?

new spec: http://www.stanford.edu/~fenn/packs/mmdb.spec
new srpm: http://www.stanford.edu/~fenn/packs/mmdb-1.09.1-6.f8.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.