[Bug 448871] Review Request: perl-Template-Provider-Encoding - Explicitly declare encodings of your templates

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Template-Provider-Encoding - Explicitly declare encodings of your templates


https://bugzilla.redhat.com/show_bug.cgi?id=448871


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-05-29 02:31 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=634268
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fddbc7b4c2033d931932880149cab323  Template-Provider-Encoding-0.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
t/00_compile....
ok
t/01_unicode....
ok
t/02_obj........
ok
All tests successful.
Files=3, Tests=30,  1 wallclock secs ( 0.80 cusr +  0.03 csys =  0.83 CPU)

+ Package: perl-Template-Provider-Encoding-0.10-1.fc9 =>
  Provides: perl(Template::Plugin::encoding) = 0.02
perl(Template::Provider::Encoding) = 0.10 perl(Template::Stash::ForceUTF8) = 0.03
  Requires: perl(:MODULE_COMPAT_5.10.0) perl(Encode) perl(Template::Config)
perl(base) perl(strict)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.