[Bug 448874] Review Request: pyroom - PyRoom is a full screen text editor and a clone of Writeroom

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyroom - PyRoom is a full screen text editor and a clone of Writeroom


https://bugzilla.redhat.com/show_bug.cgi?id=448874


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: pyroom -    |Review Request: pyroom -
                   |PyRoom is a full screen text|PyRoom is a full screen text
                   |editor and a clone of       |editor and a clone of
                   |Writeroom                   |Writeroom




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-05-29 04:18 EST -------
* rpmlint issue
---------------------------------------------------------------------
pyroom.noarch: E: description-line-too-long PyRoom is full-screen text editor,
without buttons, menu, formatting, so you can
pyroom.src: E: description-line-too-long PyRoom is full-screen text editor,
without buttons, menu, formatting, so you can
pyroom.noarch: E: description-line-too-long focus on writing, and only writing.
It is written in Python + GTK and it's Free and free.
pyroom.src: E: description-line-too-long focus on writing, and only writing. It
is written in Python + GTK and it's Free and free.
pyroom.noarch: W: devel-file-in-non-devel-package
/usr/share/pyroom/interface.glade.h
pyroom.noarch: W: invalid-license GPlv3+
pyroom.src: W: invalid-license GPlv3+
pyroom.noarch: E: no-changelogname-tag
pyroom.src: E: no-changelogname-tag
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/autosave.py
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/basic_edit.py
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/gui.py
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/interface.glade
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/preferences.py
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/pyroom_error.py
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/themes/amber.theme
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/themes/banker.theme
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/themes/blue.theme
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/themes/c64.theme
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/themes/cupid.theme
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/themes/custom.theme
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/themes/darkgreen.theme
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/themes/green.theme
pyroom.noarch: E: script-without-shebang /usr/share/pyroom/themes/locontrast.theme
pyroom.noarch: W: spurious-executable-perm /usr/share/pyroom/interface.glade.h
-------------------------------------------------------------------
  - Please fix the description
  - Please fix the license tag
  - Also fix the permissions
  - Please explain why some header files are needed
  - Please write %changelog properly

* Timestamps
  - When using "cp" or "install" commands, add "-p" option to
    keep timestamps on installed files

* python module dependency
  - Please examine the dependency for python module related rpms
    As far as I checked this package, pygtk2, pygtksourceview
    (and even more?) is needed.

* some cleanup
  - For installing gettext .mo file, perhaps something like
-----------------------------------------------------
for lang in ar ca cy da es fi fr_FR it pt pt_BR
   do
   dir=locale/$lang/LC_MESSAGES/
   %_mkdir_p $RPM_BUILD_ROOT%_datadir/$dir
   install -cpm 644 $dir/%name.mo $RPM_BUILD_ROOT%_datadir/$dir
done
-----------------------------------------------------
    is smarter?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.