[Bug 435016] Review Request: mmdb - MMDB coordinate library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mmdb - MMDB coordinate library


https://bugzilla.redhat.com/show_bug.cgi?id=435016





------- Additional Comments From fenn at stanford.edu  2008-05-29 23:42 EST -------
(In reply to comment #6)
> (In reply to comment #5)
> Much better now.
> 
> However, one major issue remains:
> # rpmlint libmmdb-1.09.1-6.fc8.x86_64.rpm
> libmmdb.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmmdb.so.0.0.0
> libmmdb.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmmdb.so.0.0.0
> 
> You renamed "main-package" into libmmdb 
> => Add "-n libmmdb" to %post and %postun
> 

done.

> 
> > > * mmdb-devel contains binaries and temporary files (*.o, .libs) in
> > > /usr/share/doc/mmdb-devel-1.09.1/Examples
> 
> > I added the following to %install:
> > 
> > pushd Examples ; make clean ; rm -rf .deps _deps ; popd
> > 
> > is that OK?
> Well, it helps for now (not a review blocker), except that it breaks 
> "rpmbuild -bi --short-circuit", because it removes files being generated
> in %build, which will kill subsequent "-bi --short-circuit".
> 
> # rpmbuild -bb mmdb.spec
> # rpmbuild -bi --short-circuit mmdb.spec
> ...
> Making install in Examples
> ...
> Makefile:336: .deps/coorfile.Po: No such file or directory
> Makefile:337: .deps/extr_exmp1.Po: No such file or directory
> Makefile:338: .deps/sel_exmp1.Po: No such file or directory
> Makefile:339: .deps/sel_exmp2.Po: No such file or directory
> Makefile:340: .deps/sel_exmp3.Po: No such file or directory
> Makefile:341: .deps/sel_exmp4.Po: No such file or directory
> Makefile:342: .deps/sel_exmp5.Po: No such file or directory
> Makefile:343: .deps/sel_exmp6.Po: No such file or directory
> Makefile:344: .deps/spseatoms.Po: No such file or directory
> make[1]: *** No rule to make target `.deps/spseatoms.Po'.  Stop.
> ...
> make: *** [install-recursive] Error 1
> error: Bad exit status from /var/tmp/rpm-tmp.6865 (%install)
> 
> Avoiding this issue is a bit tricky. 
> 
> One way is to copy Examples/ to a different directory inside of the build-tree,
> (manually) remove the temporary files there and let %doc pickup this directory
> instead of the original Examples/
> 

went with this approach.

> 
> I'll approve the package, once the ldconfig-fix is applied.
> 
> BTW: Are you familiar with rpmlint? Though it's far from being perfect, it helps
> you avoiding many of the "obvious" packaging mistakes.
> 

I just installed it and have started using it (noticed it mentioned on
fedora-list, but never actually checked it out).  Thanks for the pointer!

new spec: http://www.stanford.edu/~fenn/packs/mmdb.spec
new srpm: http://www.stanford.edu/~fenn/packs/mmdb-1.09.1-7.f8.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.