[Bug 441411] Review Request: adonthell - A 2D graphical RPG game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: adonthell - A 2D graphical RPG game


https://bugzilla.redhat.com/show_bug.cgi?id=441411





------- Additional Comments From j.w.r.degoede at hhs.nl  2008-05-31 16:16 EST -------
Looks good, I've done a full review, here are the results:

Must Fix
--------
* Currently you do:
  "sed -i 's|^CFLAGS|^#CFLAGS|g' configure.in"
  Make that:
  "sed -i 's|^CFLAGS|^#CFLAGS|g' configure"

  By modifying configure.in instead of configure, you are causing all
  the autoxxx files to be regenerated and configure being run twice
  once you've changed the sed, you can also drop the BuildRequires libtool. as
  that then won't be needed anymore either.

* Currently in the description you say:
  "inspired by good old console RPGs from the SNES like Secret of Mana or
   Chrono Trigger."

  This contains several references to protected Trademarks, please don't do that
  instaed just write (for example):
  "inspired by good old console RPGs from the 16 bit console gaming era"


Should Fix:
-----------

* The following BuildRequires are redundant and thus should be removed:
  zlib-devel, SDL-devel


So all in all the package is almost good to go, what remains is really easy to fix.

So the next step is to update your wastesedge candidate package to 0.3.5 (I
assume that together with adonthell 0.3.5 there also has been a 0.3.5 wastesedge
release) and then I'll review that next. Also it would help if that could happen
somewhat faster then the times between steps taken in this review.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.