[Bug 459088] Review Request: protobuf - Protocol Buffers - Google's data interchange format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459088





--- Comment #26 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-01 11:44:08 EDT ---
Well, for -2:

* License
  - Well protobuf.pc.in is still under ASL 2.0
    You should ask the author to change the license
    of this file
    (well, actually I have no idea why this pkgconfig
     file has license term, first of all...)
    Fortunately currently the author is in CC list
    of this bug. Rick, would you agree to change .pc.in
    file you wrote to be under BSD or to remove license
    term completely?

* BuildRequires
  - This package won't build without 
    "BuildRequires: python-setuptools-devel" (note: here
    I don't say about Requires).

* Requires
  - "Requires: %{name}-java-%{version}-%{release}" should be
    "Requires: %{name}-java = %{version}-%{release}"

* rpmlint issue
** non-standard-group
  - Group "Development/Documentation" should simply be
    "Documentation".

** non-executable-script
------------------------------------------------------------
E: non-executable-script
/usr/lib/python2.5/site-packages/google/protobuf/descriptor_pb2.py 0644
------------------------------------------------------------
   - If this script are not meant to be executed by user directly,
     then this script must not have shebang (anyway the shebang
     #!/usr/bin/python2.4 is wrong because we use python 2.5)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.