[Bug 469514] Review Request: debmirror - debian partial mirror script

bugzilla at redhat.com bugzilla at redhat.com
Sat Nov 1 20:18:55 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469514


Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no




--- Comment #3 from Terje Røsten <terjeros at phys.ntnu.no>  2008-11-01 16:18:55 EDT ---
Yes, this is simple package which could be even simpler:

rm -rf $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT/usr/bin
cp debmirror $RPM_BUILD_ROOT/usr/bin

-> 
%{__rm} -rf  %{buildroot}
%{__install} -pD -m 0755 %{name} %{buildroot}%{_bindir}/%{name}


%clean
rm -rf $RPM_BUILD_ROOT
->

%clean
%{__rm} -rf  %{buildroot}

%files
%defattr(-,root,root,-)
%doc debmirror.conf

/usr/bin/debmirror

->

%files
%defattr(-, root ,root, -)
%doc %{name}.conf
%{_bindir}/%{name}


BTW: why is the explicit req: 

Requires: perl-LockFile-Simple

needed? 

rpmbuild don't find this req. by itself?

GPL as license is not correct, is it GPLv2, GPLv2+, GPLv3 or GPLv3+ ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list