[Bug 469514] Review Request: debmirror - debian partial mirror script

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469514


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #8 from Ralf Corsepius <rc040203 at freenet.de>  2008-11-01 19:19:44 EDT ---
(In reply to comment #5)
> > Requires: perl-LockFile-Simple
> > 
> > needed? 
> 
> Probably rpmbuild finds that, that is an explicit requirement of the software,
> and it does not hurt
It is both superfluous and wrong 
(correct would be Requires: perl(LockFile::Simple)).


(In reply to comment #7)
> (In reply to comment #4)
> > and Why you don`t install debmirror.conf in %{_sysconfdir} using
> > %config(noreplace) ? also why you have included a patch moving this file to
> > $HOME ?
> 
> The patch is to avoid the /etc/debmirror.conf gets a requirement.
> The sample configuration file is not included because I build this package to
> use with cobbler, and I see easier to clear the configuration file, as most
> options must be rewritten to sync different repositories
That's not how packages are supposed to work in fedora.

IMO, this package should not be accepted with this patch.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.