[Bug 461407] Review Request: laf-plugin - Generic plugin framework for Java look-and-feels

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461407


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |rpm at greysector.net
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-02 08:36:07 EDT ---
For -1:

* License
  - As some files in the source zip are under zlib,
    the license tag must be "BSD and zlib"

* Remove redundant %doc

* Release
  - I guess it is preferable that you bump the release
    number to 2 and add some comments in %changelog
    (because of maintainer change)

* Versioning, source zip
  - The source zip in the srpm differs from what I could download
    from the URL written as %SOURCE0:
-------------------------------------------------
90874 2008-09-06 05:41 laf-plugin-1.0-1.fc9.src/laf-plugin-all.zip
54511 2008-09-15 09:01 laf-plugin-all.zip
-------------------------------------------------
    Would you check this?

! Note
  Please change the release number every time you modify your spec file/srpm
  to avoid confusion.

CC-ing to Dominik, who may be the potentional sponsor of you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.