[Bug 469492] Review Request: bam - A fast and flexible build system

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 2 18:20:34 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469492





--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk>  2008-11-02 13:20:33 EDT ---
Builds fine in mock (tried in el5).
RPMlint is silent and happy.

And there's one more issue:

6.) Please honour optflags

sh make_unix.sh

This should better be replaced with

sh -x make_unix.sh %{optflags}

(The -x is there so that the log from build output is more legible)

Note that the optflags aren't used also when you build "txt2c". Since it is not
installed, but used only during the build process, I don't believe it's an
issue. If you want to build it with optflags, add "$@" to the corresponding
line of make_unix.sh.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list