[Bug 431249] Review Request: sawfish - An extensible window manager for the X Window System.

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 2 18:49:16 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=431249


Michal Jaegermann <michal at harddata.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320229|0                           |1
        is obsolete|                            |




--- Comment #12 from Michal Jaegermann <michal at harddata.com>  2008-11-02 13:49:13 EDT ---
Created an attachment (id=322231)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=322231)
spec used to compile sawfish-1.3.4

I run into a situation where a compilation of sawfish runs into troubles in a
linking phase with complaints about multiply defined functions.  The trouble is
really caused by glib2 and how it does inlining.  A file
/usr/include/glib-2.0/glib/gutils.h is included in multiple source files and
you will get the following expansion in all these places:

extern gint
g_bit_nth_lsf (gulong mask,
        gint nth_bit)
{
  do
    {
      nth_bit++;
      if (mask & (1UL << nth_bit))
 return nth_bit;
    }
  while (nth_bit < ((4 * 8) - 1));
  return -1;
}

and other similar.  That does not work too well.

It is possible to work around glib2 troubles by defining __STRICT_ANSI__ which
indeed inlines glib2 definitions.

Attached is a spec file I used for a compilation and two patches which are
referenced there.  Additional themes were copied from old Red Hat sawfish
sources.  They do not have be included although it is nice if they are
available.

Two patches referenced in this spec are attached too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list