[Bug 469052] Review Request: ris-linux - RIS for Linux - Boot winpe from the net / Ris Windows Installation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469052





--- Comment #1 from Itamar Reis Peixoto <itamar at ispbrasil.com.br>  2008-11-02 16:35:51 EDT ---
1 - please fix macros.

replace
%{_sysconfdir}/init.d/
with
%{_initrddir} 

more info here.

https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros

2 - improve scriptlets

https://fedoraproject.org/wiki/Packaging/Guidelines#Running_scriptlets_only_in_certain_situations

http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

also when a more experienced user look your spec, he will ask to use install -p
to preserve timestamps :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.