[Bug 469080] Review Request: pidgin-musictracker - plugin for Pidgin which displays the music track currently playing in the status message

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469080


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #2 from Fabian Affolter <fabian at bernewireless.net>  2008-11-03 06:29:51 EDT ---
Just some small comments on your spec file

The current version is 0.4.11, perhaps you should update your spec file to
reflect the latest upstream version.

- Your Source0 is not working...it should be something like 
  http://%{name}.googlecode.com/files/%{name}-%{version}.tar.bz2

- In your %prep section: %setup -q is enough, because the upstream name is now
pidgin-musictracker and no longer musictracker like in the version you packed.

- You can use " find %{buildroot} -name '*.la' -exec rm -f {} ';' " in the
%install section to remove the *.la. This way to don't need to exclude those
files in the %files section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.