[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469189


Matthew Miller <mattdm at mattdm.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mattdm at mattdm.org




--- Comment #5 from Matthew Miller <mattdm at mattdm.org>  2008-11-03 11:26:37 EDT ---
Tim's package review comments look correct to me. I have a few concerns which
basically amount to documentation and features.

Documentation: The descriptive paragraph duplicated in the spec file, README,
and man page has a typo: "notifying that the system with autodie on a specific
date" should be "will autodie". (Although I'd actually like to see the word
"autodie" replaced with "remove itself from the network" -- no need to go out
of our way to scare people.) Also, "everyday" should be "every day".

There should also be a descriptive comment (maybe the same paragraph yet
again?) in system-autodeath.conf explaining what's okay there. And, it'd be
nice if there were some off values like "disabled" that could be used.

I'm also a little concerned about the default date 2009-12-01 in the current
config file. I think it should either be more conservative by default or based
on the Fedora release the package is built for. At the current rate, Fedora 10
is likely to be maintained for a month or two beyond Dec 2009. So, something
like: Fedora 8: 2009-02-25; Fedora 9: 2009-08-25; Fedora 10: 2010-02-25; etc.
This would require a little vigilance from the package maintainer as schedules
change, but would make the package useful out of the box.

Alternately, one crazy idea would be to make the default be based on the file
date of /etc/fedora-release (at package build time) + 18 months. I know you'll
hate that but throwing it out there. :)

Failing that, the default should be something like "package build time + 4
years". The last thing we want is this thing going off by accident on a
supported system.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.