[Bug 469748] Review Request: perl-MooseX-Log-Log4perl - A Logging Role for Moose based on Log::Log4perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469748


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2008-11-04 05:37:59 EDT ---
Review:
+ package builds in mock (rawhide).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=916902
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
302a2413b6faeff398cdb0a9f267e8d6  MooseX-Log-Log4perl-0.31.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave 
All tests successful.
Files=4, Tests=22,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.98 cusr  0.06
csys =  1.06 CPU)
+ Package  perl-MooseX-Log-Log4perl-0.31-1.fc10 =>
Provides: perl(MooseX::Log::Log4perl) = 0.31 perl(MooseX::Log::Log4perl::Easy)
= 0.31
Requires: perl(Log::Log4perl) perl(Moose::Role)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.