[Bug 464047] Review Request for libprojectM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464047





--- Comment #13 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-04 11:14:17 EDT ---
For -4:

* About Patch1 (libprojectM-pc-libsuffix.patch)
  - Well, with this patch LIB_INSTALL_DIR itself is expanded
    as /usr/lib{,64}, so the created libprojectM.pc contains
-------------------------------------------------
     3  libdir=/usr//usr/lib
-------------------------------------------------
    (on i386). The correct line is "libdir=/usr/lib" (on i386).

* About removing CRLF line
-------------------------------------------------
sed -i 's/\r//' ChangeLog
-------------------------------------------------
  - Please move this line to %prep (for --short-circuit issue)

Other things seem okay.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.