[Bug 458994] Review Request: liveusb-creator - A liveusb creator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458994


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at christoph-wickert.de




--- Comment #5 from Christoph Wickert <fedora at christoph-wickert.de>  2008-11-05 17:06:40 EDT ---
The %files section of this package is broken:

  %{_datadir}/*

does not work, because now liveusb-creator also owns

  %{_datadir}/applications and
  %{_datadir}/pixmaps

Kushal, please use something like

  %{_bindir}/*
  %{_sbindir}/*
  %{_datadir}/pixmaps/*.png
  %{_datadir}/applications/*.desktop

or even better: 

  %{_bindir}/%{name}
  %{_sbindir}/%{name}
  %{_datadir}/pixmaps/fedorausb.png
  %{_datadir}/applications/fedora-%{name}.desktop

This way you make sure you don't accidentally package unwanted files.

Nigel, please review more carefully next time, "No duplicate directory
ownerships" should really mean "No duplicate directory ownerships". ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.