[Bug 446989] Review Request: python-epsilon - A small utility package that depends on tools too recent for Twisted

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=446989


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-11-05 22:05:59 EDT ---
I'm sorry that you have not received a response to your submission.  If you are
still interested in submitting this package, here are a few comments:

Is there any arch-specific code in this package?  I don't see anything
compiled, and there are no binaries included in the final rpm.  Are you sure it
shouldn't be noarch?

No version of Fedora less than F8 is supported, so you should simply remove the
conditionals that refer to such old versions (especially the FC3 one; that's
long dead).  If you intend to build for EPEL then you may need some
conditionals for that, but they should be indicated as being for EPEL.  Also,
please note that the package doesn't actually work on those old releases; it
doesn't even build on F8 because your files list explicitly specifies the
egg.info file, when F8 and older don't generate one.

Your files list can be as simple as a single line:
  %{python_sitelib}/*

Is there any particular reason for the complex file list you have now?  As a
bonus, that would actually let you build on F8 without conditionalizing.

NAME.txt has DOS line endings and should be converted.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.