[Bug 447365] Review Request: llgal - generates static web-pages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=447365


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request: llgal -
                   |llgal-0.13.15 - llgal       |generates static web-pages
                   |generates static web-pages  |




--- Comment #9 from Jason Tibbitts <tibbs at math.uh.edu>  2008-11-06 10:26:51 EDT ---
I'm not sure comment #7 was followed.  Please do not define %release at all. 
Also, what's the point of appending ".noarch" to Release:?  ".noarch.i386.rpm"
is... not a good idea.  If you want to build a noarch package, add "BuildArch:
noarch".

Please don't start the Summary: with the name of the package.
  llgal - llgal generates whatever
is rather redundant.

You need to submit a src.rpm, not a built binary package.  We need to be able
to build the package you submit for ourselves.

A package cannot put things in /usr/local under any circumstances.  (Well, your
personal packages can do so; that's your business.  But no packages in the
distro can do so.)  If the upstream insists on that, it will need to be fixed
or patched.

Don't put eval in your files list.  Just use the standard defines for Perl
modules.

Use macros in your files list; instead of hardcoding /usr/bin, use %{_bindir}.

This package fails to own /usr/share/llgal.

Your files list can be much simpler in any case:
  %files
  %{_bindir}/llgal
  %{_datadir}/llgal/
  %{perl_vendorlib}/*
Or at least I think that would do it; I don't have the sources to build from in
order to test.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.