[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469590


Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|dan at danny.cz                |
         AssignedTo|nobody at fedoraproject.org    |dan at danny.cz
               Flag|                            |fedora-review?




--- Comment #3 from Dan Horák <dan at danny.cz>  2008-11-06 11:12:01 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     0aac0d5104e45421ce3c48f0fe2d924d0d13caf1  cpuid-20060917.src.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
BAD license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
BAD compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.


- license should be MIT instead of BSD
(http://fedoraproject.org/wiki/Licensing/MIT)
- $RPM_OPT_FLAGS are not used to compile, could be solved with
    make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS -D_FILE_OFFSET_BITS=64
-DVERSION=$(VERSION)"
- rpmlint complains
    cpuid.src:48: W: macro-in-%changelog doc => make it "... %%doc ..."

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.