[Bug 245561] Review Request: ht - File editor/viewer/analyzer for executables

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=245561


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #13 from Till Maas <opensource at till.name>  2008-11-06 16:04:07 EDT ---
Sorry for the delay. The %optflags are still not OK:

NOT OK:
There is still fomit-frame-pointer and -O3 in the compiler flags, e.g.:

if g++ -DHAVE_CONFIG_H -I. -I. -I. -I./analyser -I./asm -I./info -I./io/posix
-I./io -I./output -I./eval -I.    -DNOMACROS -pipe -O3 -fomit-frame-pointer
-Wall -fsigned-char -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-Woverloaded-virtual -Wnon-virtual-dtor -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -MT htcfg.o -MD -MP -MF ".deps/htcfg.Tpo" -c -o ht


[NEEDS WORK] rpmlint output:
ht.i386: W: file-not-utf8 /usr/share/doc/ht-2.0.14/TODO
The file should be converted to UTF, e.g. with BR: recode and this in %prep:
recode latin1..utf8 TODO
Or some iconv/touch lines.

ht-debuginfo.i386: E: non-standard-executable-perm
/usr/src/debug/ht-2.0.14/endianess.cc 0775
ht-debuginfo.i386: E: script-without-shebang
/usr/src/debug/ht-2.0.14/endianess.cc
endianess.cc is executable in the tarball, the group writable comes from my
setup. Imho should rpmbuild create sane permissions for debuginfo contents.
But you could also ask upstream to remove the executable bit from the source
file.


[OK] Spec in %{name}.spec format

[OK] license allowed: GPLv2
[OK] license matches shortname in License
[OK] license in tarball and included in %doc: COPYING

[OK] package is code or permissive content
{OK} patches sent to upstream and commented
[OK] Source0 is a working URL
{OK} Sourceforge URL is Source0:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
[OK] Source0 matches Upstream:
b3721a82532ba24bbfbc7f812b218217  ht-2.0.14.tar.bz2

[OK] Package builds on all platforms:
http://koji.fedoraproject.org/koji/taskinfo?taskID=920089
[OK] BuildRequires are complete (mock builds)
(OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin 
[OK] %find_lang used for locales

[N/A] Every (sub)package containing libraries runs ldconfig
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
[N/A] .h (header) files are in -devel subpackage
[N/A] .a (static libraries) are in -static subpackage
[N/A] contains .pc (pkgconfig) files and has Requires: pkgconfig
(N/A) .pc files are in -devel subpackage
[N/A] contains .so.X(.Y) files and .so is in -devel
[N/A] -devel subpackage has Requires: %{name} = %{version}-%{release}
[N/A] .la files (libtool) are not included


[N/A] Has GUI and includes %{name}.desktop
[N/A] .desktop file installed with desktop-file-install in %install

[OK] Prefix: /usr not used (not relocatable)

[OK] Owns all created directories
[OK] no duplicates in %files
[OK] %defattr(-,root,root,-) is in every %files section
[OK] Does not own files or dirs from other packages
[OK] included filenames are in UTF-8

[OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT 
[OK] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT 

[OK] Consistent macro usage
[OK] large documentation is -doc subpackage
[OK] %doc does not affect runtime

{OK} no pre-built binaries (.a, .so*, executable)
{OK} well known BuildRoot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
{OK} PreReq not used
{OK} no duplication of system libraries
{OK} no rpath
{OK} Timestamps preserved with cp and install
{OK} Uses parallel make (%{?_smp_mflags})
{OK} Requires(pre,post) style notation not used
{OK} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and
%{buildroot} on %install and %clean)
{OK} no Conflicts
{OK} nothing installed in /srv
{OK} Changelog in allowed format
{OK} does not use Scriptlets
<OK> Sane Provides: and Requires:

{OK} Follows Naming Guidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.