[Bug 464054] Package Review Request for projectM-pulseaudio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464054





--- Comment #3 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-11-06 20:24:14 EDT ---
OK, here's the rest of the review:

* The files AUTHORS and NEWS are empty and useless. It's ok to not package
them. But keep an eye on them whenever there is an update by upstream.

* Requires: libprojectM = %{version}
is definitely not needed. I'm not very sure about the 
  Requires: pulseaudio
rpmbuild picks up pulseaudio-libs as a dependency. This is probably enough. Is
there a particular reason why you required pulseaudio?

* The line 
   find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
doesn't seem necessary since no .la files are built. Is this also true for
libprojectM-qt? Can you check?

* Please make use of the %{name} macro whenever possible, e.g. in the %install
and %files sections.

* It would be nice if you add a Generic Name to the .desktop file. Also
"Application" is forbidden in the category field.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.