[Bug 460352] Review Request: xwota - Who's On the Air Database interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460352





--- Comment #5 from Lucian Langa <cooly at gnome.eu.org>  2008-11-07 01:36:14 EDT ---

> Is there any point to mentioning what operating systems the program works on? 
> Does that even matter for a Fedora package?
dropped the part.


> I note the following complaint from desktop-file-install:
> /builddir/build/BUILDROOT/xwota-0.4-4.fc10.x86_64/usr/share/applications/xwota.desktop:
> warning: value "xwota.png" for key "Icon" in group "Desktop Entry" is an icon
> name with an extension, but there should be no extension as described in the
> Icon Theme Specification if the value is not an absolute path
fixed


> So just fix that and the license tag and the desktop file up and this should be
> ready to go.
fixed


> Finally, I note that you have submitted 24 packages for review, while you've
> only reviewed three packages.  I will periodically revisit your packages as I
> work through the queue and I suppose eventually all of them will be reviewed
> but the reviewers are much more likely to review your packages if you do some
> more reviews yourself.
fixing...

new version:
http://lucilanga.fedorapeople.org/xwota.spec
http://lucilanga.fedorapeople.org/xwota-0.4-5.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.