[Bug 469814] Review Request: fuse-zip - Fuse-zip is a fs to navigate, extract, create and modify ZIP archives

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469814


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #3 from Till Maas <opensource at till.name>  2008-11-07 07:03:28 EDT ---
In %build I would also add LDFLAGS, because otherwise g++ is once called
without these flags (g++  fuse-zip.o fileNode.o bigBuffer.o fuseZipData.o
libZipWrapper.o -pthread -L/lib -lfuse -lrt -ldl   -lzip -lz   -o fuse-zip):


make %{?_smp_mflags} CXXFLAGS="$RPM_OPT_FLAGS" LDFLAGS="$RPM_OPT_FLAGS"



Instead of the sed and the DESTDIR you can better use this here in %install:
make install INSTALLPREFIX="$RPM_BUILD_ROOT/%{_prefix}"

DESTDIR is not used in the makefile, so you do not need to use it for make
install.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.