[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469673





--- Comment #4 from Stepan Kasal <skasal at redhat.com>  2008-11-07 10:36:28 EDT ---
OK  source files match upstream:
    sha256sum: 1f528cd3fe2086b14f2992c4525a5cd697fb53c7cc8505bf5adeb78793e40b18
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  dist tag is present.
OK  build root is correct.
OK  license field matches the actual license.
OK  license is open source-compatible.
OK  license text included in package.
OK  latest version is being packaged.
OK  BuildRequires are proper.
OK  %clean is present.
OK  package builds in mock.
OK  package installs properly.
OK  no debuginfo package
OK  rpmlint is silent.
BAD final provides and requires are sane -- see below
OK  %check is present and all tests pass:
      t/01_compile........ok
      t/02_without_par....ok
      t/03_with_par.......ok
      All tests successful.
      Files=3, Tests=60,  2 wallclock secs
      Result: PASS
OK  no shared libraries
OK  owns the directories it creates.
BAD owns directories created by perl-File-ShareDir; please replace
      %{perl_vendorlib}/*
    with
      %{perl_vendorlib}/File/ShareDir
      %{perl_vendorlib}/auto/share/*/File-ShareDir-PAR
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  no scriptlets present.
OK  code, not content.
OK  documentation is small, so no -docs subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.  no pkgconfig files.  no libtool .la droppings.
OK  no desktop files

There are three redundant manual requires:
Requires:       perl(Class::Inspector) >= 1.12
Requires:       perl(File::ShareDir)
Requires:       perl(Params::Util) >= 0.07
But all there requires are also detected automatically.
To add the version requirements, I suggest to patch PAR.rpm this way:
sed -i "
s/^use Params::Util  *'/use Params::Util 0.07 '/
s/^use Class::Inspector  *()/use Class::Inspector 1.12 ()/
" lib/File/ShareDir/PAR.pm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.