[Bug 452749] Review Request: ocp - Open Cubic Player for MOD/S3M/XM/IT/SID/MIDI music files

bugzilla at redhat.com bugzilla at redhat.com
Fri Nov 7 16:02:02 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=452749


Dominik 'Rathann' Mierzejewski <rpm at greysector.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #12 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2008-11-07 11:01:59 EDT ---
missing Requires: hicolor-icon-theme (for the hicolor icon dirs)

...
# remove wmconfig stuff
rm -rf %{buildroot}/etc/X11/wmconfig/
rmdir %{buildroot}/etc/X11

These two could be shortened to:
rm -rf %{buildroot}/etc/X11

...
%{_bindir}/ultrafix.sh

This could be renamed to ocp-ultrafix.sh.

You can fix these issues after importing the package.

Package APPROVED and you are now sponsored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list