[Bug 470140] Review Request: nettee - Network "tee" program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470140


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #1 from Till Maas <opensource at till.name>  2008-11-07 11:35:14 EDT ---
- These two lines can probably be removed from %build
#acc. README.txt
#gcc -Wall -D_LARGEFILE64_SOURCE -o nettee nettee.c

- The find commandline looks too complex to me, "chmod 644 *.sh" does afaics
the same job

- The spec is not honouring the %optflags[0], e.g. use this in %build:

%{__cc} %{optflags}  -D_LARGEFILE64_SOURCE -o nettee nettee.c

- With the %opflags set, it does not compile:
In line 868 open is used with O_CREAT, but without default permissions of the
file to be created. I will attach a patch that will fix this. If you add the
patch to the package, please mention that this is already fixed in the
development version (0.2.0 beta)[1]


[0] https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
[1] https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.