Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=443238
Jason Tibbitts <tibbs at math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |tibbs at math.uh.edu
Flag| |fedora-review?
--- Comment #16 from Jason Tibbitts <tibbs at math.uh.edu> 2008-11-07 12:29:41 EDT ---
Unfortunately I have no way to test this; it doesn't over a remote X
connection. I got someone on IRC to test it and it works fine.
I get the following from rpmlint:
cave9.x86_64: E: non-standard-executable-perm /usr/bin/cave9 0775
This doesn't happen in the buildsys so it must be some weirdness with my local
setup, but you really should force the permissions just in case, either by
using install -p -m 755 or by running chmod manually.
You need to document which parts of the package are under which licenses. See
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios
for some suggestions on how to go about doing this. It should be sufficient to
indicate that the code is GPLv3+ and the licenses for the data are indicated in
data_README.txt. Also, you are missing an "and Public Domain" for the
NASA-produced sounds.
%description is a complete sentence and should end with a period.
* source files match upstream:
89a1ef99f2399bf7638b25ce4b51c5c088e01c29bc407eab689ccbb39c5b8d39
cave9_data-4.tgz
569d311b4f02d3b25ed98051b752bb3606fc243f0f1a7a0c8901c4569eceb11f
cave9_src-0.3.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
X description needs a trailing period.
* dist tag is present.
* build root is OK.
X license field missing "and Public Domain".
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
X rpmlint has a valid complaint.
* final provides and requires are sane:
cave9 = 0.3-2.fc10
cave9(x86-64) = 0.3-2.fc10
=
dejavu-fonts
libGL.so.1()(64bit)
libGLU.so.1()(64bit)
libSDL-1.2.so.0()(64bit)
libSDL_image-1.2.so.0()(64bit)
libSDL_ttf-2.0.so.0()(64bit)
* %check is not present; no way to test this automatically. Testing indicates
that it works fine.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X error in file permissions.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
* desktop files valid and installed properly.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.