[Bug 435017] Review Request: SSM - coordinate superposition library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=435017


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #11 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-08 02:35:23 EDT ---
For -8:

* License
  - The license tag should be LGPLv2+.

* BuildRequires
  - This package won't build without "BuildRequires: mmdb-devel".

* configure option
------------------------------------------------------------
    55  ++ pkg-config --variable=prefix mmdb
    56  + ./configure --build=i386-redhat-linux-gnu
--host=i386-redhat-linux-gnu --target=i386-redhat-linux-gnu --program-prefix=
--prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin
--sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include
--libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var
--sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/usr/share/info
--with-mmdb=/usr --disable-static
    57  configure: WARNING: unrecognized options: --with-mmdb
------------------------------------------------------------
  - Is the option "--with-mmdb=foo" useful?

* Timestamps
------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT install='install -p'
------------------------------------------------------------
  - The last argument should be "INSTALL='install -p'".

* Document
  - There is no need that -devel subpackage should own the same
    document files in main package.

* rpmlint
**  undefined-non-weak-symbol
    - "$ rpmlint ssm" (please try rpmlint for 'installed' ssm) shows
      that libssm.so.0 contains many undefined non-weak symbols.
      !  You can check this also by $ ldd -r %_libdir/libssm.so.0
      For packages providing -devel subpackage this cannot be
      allowed because this causes linkage error.

      I guess making libssm.so linked against libmmdb.so will fix this
      issue
      (because
       LD_PRELOAD=%_libdir/libmmdb.so.0.0.0 ldd -r %_libdir/libssm.so.0.0.0
       shows no undefined non-weak symbols)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.