[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 9 11:28:32 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469590





--- Comment #6 from Fabian Affolter <fabian at bernewireless.net>  2008-11-09 06:28:31 EDT ---
Thanks again

(In reply to comment #5)
> (In reply to comment #4)
> > 
> > > - $RPM_OPT_FLAGS are not used to compile, could be solved with
> > >     make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS -D_FILE_OFFSET_BITS=64
> > > -DVERSION=$(VERSION)"
> > 
> 
> Hm, the VERSION is now undefined during the compile. But after reading the
> Makefile, the proper solution would be to use "-DVERSION=%{version}" in the
> CFLAGS. So, please, one more iteration is required, all other issues have
> already been resolved.

New make:

make %{?_smp_mflags} CFLAGS="%{optflags} -D_FILE_OFFSET_BITS=64
-DVERSION=%{version}"

Update:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/cpuid.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/cpuid-20060917-4.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list