[Bug 470694] Review Request: rubygem-rack - Common API for connecting web frameworks, web servers and layers of software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470694





--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-09 09:10:34 EDT ---
For 0.4.0-1

* ruby(abi) dependency
  - Please check
    https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

* Unused macro
  - %ruby_sitelib does not to be used anywhere.

* Dependency
  - Please check if all needed Requires are added properly.
    ! For example, lib/rack/handler/mongrel.rb contains
----------------------------------------------------------
     1  require 'mongrel'
     2  require 'stringio'
----------------------------------------------------------
      So this file has "Requires: rubygem(mongrel)".
      However I don't know if this file itself is just optional
      or not.
      Anyway please check if all dependencies are correctly added.

* %gemdir/bin
  - I guess files under %gemdir/bin must be moved into
    %_bindir (ref: rubygem-mongrel.spec)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.