[Bug 470696] Review Request: rubygem-passenger - Passenger Ruby on Rails deployment system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470696





--- Comment #5 from Jeroen van Meeuwen <kanarip at kanarip.com>  2008-11-09 15:29:23 EDT ---
(In reply to comment #2)
> First of all, the overall license this package is GPLv2 (not GPLv2+)

The license tag actually says GPLv2, not GPLv2+

(In reply to comment #3)
> By the way some pre-remarks
> 
> * BuildRequires
>   - This package won't build without "BR: rubygem(fastthread)".

Added BuildRequires: rubygem(fastthread) >= 1.0.1

>   - "BR: gcc-c++ findutils" are redundant.
> 

Removed these.

> * Requires
>   - Please check if all needed Requires are correctly added.
>     It seems that at least "Requires: rubygem(rack)
>     rubygem(fastthread)" are needed.
> 

Added these requires

> * boost dependency
>   - Well, when I try below to make build log more verbose
>     (please consider this)
(...snip...)
> -------------------------------------------------------
>      Here
>      - This package seem to be using internal libboost_thread library.
>        This should be changed so that mod_passenger.so uses external (system-
>        widely provided) libboost_thread-mt.so library
>      - Anyway Fedora specific compilation flags are not correctly honored.
> 

I seem unable to do this. Logfile attached

> * Redundant output
>   - I guess the "-v" option of "chmod -v 644 $script" is not needed...
>     (Actually you are not using -v option for chmod on the below lines)
>   - Also I guess rm -r"v"f is redundant...
> 

It's redundant, but it shows which files are chmod'ed or rm'ed; since it's a
find with a couple of parameters I'd like to be able to track down what
happens.

> * Document files
>   - You don't have to write %doc attribute for files under %_mandir
>     (as these are automatically regarded as %doc)
> 

Fixed.

> * Directory ownership issue
>   - Please own %{ruby_sitearch}/passenger/
>   - Please also check the directory ownership issues between subpackages.
>     ! For example
>       - The directory %{geminstdir}/doc is owned by -doc subpackage
>       - -devel subpackage has %{geminstdir}/doc/definitions.h
>       - -devel subpackage does not have "Requires: -doc"
>       - So when -devel subpackage is installed with_out_ -doc subpackage
>         installed, %{geminstdir}/doc is not owned by any packages
> 

Made %{geminstdir} shared between -devel and -doc package.

> * %defattr
>   - is missing on mod_passenger subpackage.

Fixed.

New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-passenger.spec
New SRPM:
http://www.kanarip.com/custom/f9/SRPMS/rubygem-passenger-2.0.3-3.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.