[Bug 468467] Review Request: gksu - Graphical frontend to su

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468467


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2008-11-10 07:06:24 EDT ---
Some quick comments...

- You added 'BuildRequires: gettext-devel' 'BuildRequires: gettext' is
sufficient 

- I guess that all patches are coming from Debian. Am I right?
 
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

- Is rpmlint not complaining about the NEWS file?

- In this tarball is a .desktop file too.  You should add it. 
  libgksu:  gksu-properties.desktop
  gksu:     gksu.desktop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.