[Bug 470626] Review Request: balance - TCP load-balancing proxy server with round robin and failover mechanisms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470626


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2008-11-10 13:13:31 EDT ---
Some comments on your spec file:

- 'Patch0: disable_IPV6_V6ONLY_check_for_now.patch' Where is patch coming from?
  https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus

- Where is balance.pdf (manual page) from the source going?  I thinks that this
pdf is not really necessary but what are the guidelines telling?

- You can simplify your %build section if you like by summarize the commands

mkdir -p %{buildroot}%{_sbindir}
install -m 755 balance  %{buildroot}%{_sbindir}/%{name}
->
install -Dp -m 0755 %{name} %{buildroot}%{_sbindir}/%{name}

and

mkdir -p %{buildroot}%{_mandir}/man1
install -m 644 balance.1 %{buildroot}%{_mandir}/man1
->
install -Dp -m 0644 %{name}.1 %{buildroot}%{_mandir}/man1/%{name}.1

- %dir /var/run/balance should be ->  %dir %{_localstatedir}/run/%{name}
  %{_localstatedir} is mandatory, using the %{name} macro optional
  Package consistently uses macros.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.