[Bug 467655] Review Request: yafaray - a raytracer for Blender.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655





--- Comment #26 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2008-11-10 18:54:47 EDT ---
quick comments. I will have more time on wednesday...

The snapshot is good, can be I've regenerated  from today and the package built
fine.

What need to be improved.
* The package release should notice it is a snapshot. So, either the version
(0.1.0) is pre, or post. then the release will be <1 (aka:
0.1svn%{date}%{?dist} or >1 ( 1svn%{date}%{?dist}.

* Package must use our $RPM_OPT_CFLAGS.
For now it use -O3 -ffast-math, you will probably need another dynamic patch
here as $RPM_OPT_CFLAGS depends on the cpu architecture.


* rpmlint on installed packages (rpmlint yafaray yafaray-blender) aren't empty,
specially there are a lot of undefined-non-weak-symbols. This is because of a
missing library at linking time, This have to be repored upstream. 
/usr/lib64/_yafqt.so
/usr/lib64/_yafrayinterface.so

* I still cannot have yarafray blender plugin detected when
blender-2.48a-4.fc8.x86_64 is used. I will ivestigate this, but maybe it would
be easier to define a blender python plugins directory within the python libdir
pathes.

%{python_sitearch}/blender/ for architecture dependent plugin (like yafaray)
%{python_sitelib}/blender for architecture independant plugin.

Then every files from a given plugin will be shipped either in the architecture
dependent python directory or the architecture independent one...
I will give more testing on wednesday as i'm not sure for now...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.