[Bug 461929] Review Request: mnemosyne - Flash-card learning tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461929





--- Comment #8 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2008-11-11 13:12:47 EDT ---
(In reply to comment #5)
> koji build:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=913629
> 
> You are building a noarch python package.
> Using CFLAGS is irrelevant. (it is replaced as -O2 only as noarch package).
> 
> In the install section, why do you need to install twice ?
> %{__python} setup.py install -O1 --skip-build --root %{buildroot}
> should be enought. (at least there is the same set of files with this method).

I just copied those two lines from
https://fedoraproject.org/wiki/Packaging/Python

Line removed.

> Gnome HIG recommends to use verb(s) in comments for desktop files...
> http://developer.gnome.org/projects/gup/hig/1.0/

Fixed.

(In reply to comment #7)
> You need to add Requires: hicolor-icon-theme for the
> /usr/share/icons/hicolor/128x128/apps/ directory.

Fixed.

Updated package:

http://rathann.fedorapeople.org/review/mnemosyne.spec
http://rathann.fedorapeople.org/review/mnemosyne-1.1.1-3.r1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.