[Bug 471041] Review Request: diffpdf - PDF files comparator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471041





--- Comment #3 from Fabian Affolter <fabian at bernewireless.net>  2008-11-12 17:41:34 EDT ---
After a fast look at the spec file, it looks good to me.  If nobody is
interested in doing the review, I will do it.

You can convert two lines into one if you like...

mkdir -p $RPM_BUILD_ROOT%{_bindir}
install -m 755 diffpdf $RPM_BUILD_ROOT%{_bindir}

-> install -Dp -m 0755 %{name} %{buildroot}%{_bindir}/%{name}

but don't mix %{buildroot} and $RPM_BUILD_ROOT

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=929672

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.