[Bug 471373] Review Request: rmanage - Remotely monitoring machines on network

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471373


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2008-11-13 08:10:37 EDT ---
Just some comment on your spec file...

- 'desktop-file-install --vendor="fedora" \' is obsolete for new packages.
   Check https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor

- You are mixing $RPM_BUILD_ROOT and %{buildroot} . That should not be done.
 
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

- There is a po directory in the source. The tool provides translation. But 
  BuildRequires: gettext, %find_lang %{name}, and %files -f %{name}.lang are
missing.
  https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.