[Bug 468579] Review Request: PyQuante - Python Quantum Chemistry

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468579





--- Comment #4 from Jussi Lehtola <jussi.lehtola at iki.fi>  2008-11-13 09:13:27 EDT ---
(In reply to comment #1)
> Only some quick comment about the rpmlint output and your spec file...
> 
> Spec file:
> 
> Detail about packaging python stuff:
> https://fedoraproject.org/wiki/Packaging/Python
> 
> Name: PyQuante
>  - The name of your package should be lower case
>    https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Case_Sensitivity

The author refers to the software as PyQuante, also the python modules are
called PyQuante. Refer to ORBit in Naming Guidelines.

> BuildRequires
>  - 'BuildRequires:   python' is missing

It is already required by python-setuptools-devel (and numpy too?).

> % files
>  - Please follow the guidelines
> https://fedoraproject.org/wiki/Packaging/Python#System_Architecture

Hmm, I thought I already was following them. I can't find anything wrong with
using %{python_sitearch} as defined in the Python guidelines. PyQuante contains
compiled C code in the modules..

>> PyQuante.x86_64: E: non-executable-script
>> /usr/lib64/python2.5/site-packages/PyQuante/Minimizers.py 0644
>
>You can add something like 'find  *.py -type f | xargs chmod a+x' to fix this.

If I do that then I get script-without-shebang errors.
Besides, the files in site-packages don't need to be executable, since they
just contain modules used by the frontend software.

Check your python-sitelib directory, only a small minority of the .py files are
executable. rpmlint shouldn't complain about this.

> > PyQuante.x86_64: W: invalid-license Modified BSD
> > PyQuante-debuginfo.x86_64: W: invalid-license Modified BSD
> 
> For a valid license for Fedora, please take a look at
> https://fedoraproject.org/wiki/Licensing

Yeah, but the license is not word-for-word BSD.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante-1.6.1-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.