[Bug 471429] Review Request: perl-Catalyst-Engine-Apache - Catalyst Apache Engines

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471429


Chris Weyl <cweyl at alumni.drew.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cweyl at alumni.drew.edu
         AssignedTo|nobody at fedoraproject.org    |cweyl at alumni.drew.edu
               Flag|                            |fedora-review+




--- Comment #2 from Chris Weyl <cweyl at alumni.drew.edu>  2008-11-13 14:41:32 EDT ---
Everything looks good.

I note that the author has a rather decent test suite, but has not chosen to
enable it, for whatever reason.  (Makefile.PL explicitly specifies the tests as
being only 't/0*.t'.)  They all pass when I run them independently (with minor
patches to change 01use.t to 02pod.t), but as upstream has them disabled, it's
not a blocker.  (I would suggest filing a bug upstream, asking if this is
intentional, however.)

http://koji.fedoraproject.org/koji/taskinfo?taskID=931745

Spec looks sane, clean and consistent; license is correct (perl); make test
passes cleanly.

00d89cac86ed977428468433389f4c6e  Catalyst-Engine-Apache-1.12.tar.gz
00d89cac86ed977428468433389f4c6e  Catalyst-Engine-Apache-1.12.tar.gz.srpm

=====> perl-Catalyst-Engine-Apache-1.12-2.fc9.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Catalyst-Engine-Apache-1.12-2.fc9.noarch.rpm
perl(Catalyst::Engine::Apache) = 1.12
perl(Catalyst::Engine::Apache2)  
perl(Catalyst::Engine::Apache2::MP20)  
perl-Catalyst-Engine-Apache = 1.12-2.fc9
====> requires for perl-Catalyst-Engine-Apache-1.12-2.fc9.noarch.rpm
perl(:MODULE_COMPAT_5.10.0)  
perl(APR::Table)  
perl(Apache2::Connection)  
perl(Apache2::Const)  
perl(Apache2::RequestIO)  
perl(Apache2::RequestRec)  
perl(Apache2::RequestUtil)  
perl(Apache2::Response)  
perl(Apache2::URI)  
perl(Catalyst::Runtime)  
perl(File::Spec)  
perl(URI)  
perl(URI::http)  
perl(URI::https)  
perl(base)  
perl(constant)  
perl(strict)  
perl(warnings) 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.