[Bug 226166] Merge Review: mtx

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226166


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |orcanbahri at yahoo.com,
                   |                            |rbrich at redhat.com
         AssignedTo|nobody at fedoraproject.org    |orcanbahri at yahoo.com
               Flag|                            |fedora-review?




--- Comment #3 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-11-13 17:13:11 EDT ---
I made a full review on this package. Here are my notes:

* rpmlint says:
   mtx.x86_64: W: spurious-executable-perm
/usr/share/doc/mtx-1.3.12/contrib/config_sgen_solaris.sh
   mtx.x86_64: W: spurious-executable-perm
/usr/share/doc/mtx-1.3.12/contrib/mtx-changer
Please fix these. Actually, most of the contents of the contrib directory don't
belong to %doc. Also this directory contains .tar.gz files. Those should be
extracted and put in the appropriate places, and if necessary, be published as
subpackages.

* We prefer %defattr (-,root,root,-)

* The default prefix is set as /usr/local in the configure script. And the
default libdir is the hardcoded /usr/lib. I'm not sure if these have any effect
during runtime. Please check and fix if necessary.

* Most of the scripts in the contrib directory (even those in the tarballs)
point to /usr/local, /usr/local/sbin too. Please fix those.

* It would be more consistent with other macros you use if you prefer
%{optflags} instead of $RPM_OPT_FLAGS

* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.