[Bug 471522] Review Request: OTL - OTL library for database connections and queries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471522





--- Comment #2 from Peter Lemenkov <lemenkov at gmail.com>  2008-11-14 06:12:17 EDT ---
Notes: 

* You forgot to add %prep section to your spec-file (where rpmbuild should
unzip sources). Please add 

%prep
%setup -q -c


This means that rpmbuild will create default directory in BUILD
(%{name}-%{version}), cd into it and will quietly unzip %{SOURCE0}

* Add empty %build section (just to make rpmlint happy)

* You should use mighty power of 'install' command instead of creating
directory my hands :). E.g. instead of

mkdir -p $RPM_BUILD_ROOT%{_includedir}/otl
cp -a otlv4.h $RPM_BUILD_ROOT%{_includedir}/otl

you may use

install -D -p -m 644 otlv4.h $RPM_BUILD_ROOT%{_includedir}/%{name}/otlv4.h

* Please split %description in shorter lines (to silent rpmlint):

otl.src: E: description-line-too-long OTL 4.0 was designed as a combination of
a C++ template framework and OTL-adapters.
otl.src: E: description-line-too-long The framework is a generic implementation
of the concept of OTL streams. The OTL-adapters
otl.src: E: description-line-too-long are thin wrappers around the database
APIs and are used as class type parameters

Other things looks sane.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.