[Bug 471026] Review Request: chrony - An NTP client/server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471026





--- Comment #1 from Dan Horák <dan at danny.cz>  2008-11-14 08:41:34 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     f0c6b32099329f358dbdb4f62753d2c7cbc13c79  chrony-1.23.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
?? rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
?? correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.


- rpmlint complains a bit
chrony.src:52: W: configure-without-libdir-spec
    hand-crafted configure script, can be ignored

chrony.x86_64: W: non-standard-uid /var/lib/chrony chrony
chrony.x86_64: W: non-standard-gid /var/lib/chrony chrony
chrony.x86_64: W: non-standard-uid /var/log/chrony chrony
chrony.x86_64: W: non-standard-gid /var/log/chrony chrony
chrony.x86_64: W: non-standard-uid /var/lib/chrony/rtc chrony
chrony.x86_64: W: non-standard-gid /var/lib/chrony/rtc chrony
chrony.x86_64: W: non-standard-uid /var/lib/chrony/drift chrony
chrony.x86_64: W: non-standard-gid /var/lib/chrony/drift chrony
    OK

chrony.x86_64: E: non-readable /etc/chrony.keys 0600
    OK

chrony.x86_64: W: log-files-without-logrotate /var/log/chrony
    does chrony rotate the logs itself or ...?

- the texinfo postun scriptlet is called at wrong occasion
(https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.